Commit Graph

116 Commits

Author SHA1 Message Date
Bradlee Speice
cb8ea71f62 Code coverage is working!
Been trying so long to get this running, so happy to have it done.
2014-11-17 16:49:28 -05:00
DjBushido
8d6a3b0d84 Slight refactoring of BibleMenu
Needs a test case, but having issues with the emulator on Windows
2014-11-16 00:28:25 -05:00
Bradlee Speice
6c139eacab Make the VerseContent immutable
Not quite certain this is the way to go, but let's try a functional experiment.
2014-11-13 00:04:20 -05:00
Bradlee Speice
1ee1a41004 Switch get() to [] 2014-11-12 23:43:21 -05:00
Bradlee Speice
187a73cf92 Kotlin migration is done!
There will of course be refactoring and whatnot, but I consider this an accomplishment.
2014-11-12 23:41:05 -05:00
Bradlee Speice
0e7680ca9e Rename the ExpListNavDrawerFragment 2014-11-12 22:21:32 -05:00
Bradlee Speice
18c9df404e Books are now deleted correctly
Still need to handle all the network related errors...
2014-11-12 01:01:34 -05:00
Bradlee Speice
8137c4795a Fix issues the OsisParser regenerating VerseContent
BookManager is still currently unable to delete books
2014-11-12 00:34:31 -05:00
Bradlee Speice
cce463cde9 Properly remove a book
Not sure why it needs to be implemented this way...
2014-11-12 00:09:24 -05:00
Bradlee Speice
b65b5680f9 Remove the InstalledManager
Largely duplicated work, and makes testing easier!
2014-11-11 23:46:51 -05:00
Bradlee Speice
35b515add7 Small documentation update on Injector 2014-11-11 23:26:01 -05:00
Bradlee Speice
7cfe273cb6 Refactor BookDownloadManager to Kotlin
I don't like that I had to make one static method a class method, but I like how much cleaner everything else is!
2014-11-11 22:55:31 -05:00
Bradlee Speice
86adeb4951 Refactor the DLProgressEvent to Kotlin 2014-11-11 21:53:13 -05:00
Bradlee Speice
b778748ee0 Rename FinalDelegate to SafeValDelegate 2014-11-11 13:29:55 -05:00
Bradlee Speice
c394fce273 Use a delegate to make OsisParser cleaner 2014-11-11 10:09:47 -05:00
Bradlee Speice
c57babd68a Add some tests to the OsisParser
Testing state machines can be difficult if it's not black box...
2014-11-11 00:33:51 -05:00
Bradlee Speice
6a45d872f8 Refactor the Core of LocaleManager, test it 2014-11-10 23:45:21 -05:00
Bradlee Speice
d7e9dd34c9 Expose the modulesByLanguage
Can be refactored later, internal implementation uses the "proper" way of accessing things.
2014-11-08 00:34:08 -05:00
Bradlee Speice
1ea27f50b9 Slight refactor, FixedLanguage should be private 2014-11-08 00:29:10 -05:00
Bradlee Speice
cc15e9219d Some slight refactoring, test filtering books 2014-11-08 00:22:13 -05:00
Bradlee Speice
ad1a0eee84 Boundary Value testing working as hoped. 2014-11-07 00:27:17 -05:00
Bradlee Speice
c0281cc8c7 Working language selector! 2014-11-07 00:11:05 -05:00
Bradlee Speice
88a40cbfbb Add a language spinner
It doesn't do much yet...
2014-11-06 23:13:45 -05:00
Bradlee Speice
23bd5136b5 Provide access to network state
Also fix the no books installed issue (again)
2014-11-06 20:06:17 -05:00
Bradlee Speice
72f375ff9f Revert "Remove the build flavors"
This reverts commit c38dad605a.
2014-11-06 19:57:13 -05:00
Bradlee Speice
c38dad605a Remove the build flavors
This is actually a pretty big accomplishment, should be a blog post shortly.
2014-10-30 00:42:23 -04:00
Bradlee Speice
1eb914819d Refactor main menu to Kotlin
So much less code to write and maintain... love it.
2014-10-24 23:53:39 -04:00
Bradlee Speice
8104ffa862 Test case refactoring, test doUpdate
Boundary Values are awesome - https://www.destroyallsoftware.com/talks/boundaries
2014-10-22 23:32:18 -04:00
Bradlee Speice
f4e8ffaebc Some more cleanup and additions
Android is seriously not test-friendly
2014-10-22 23:16:52 -04:00
Bradlee Speice
22fd32b26d RefreshManager going functional! 2014-10-22 22:21:42 -04:00
Bradlee Speice
9424d43ef7 Not pretty, but displays verse at top of screen 2014-10-12 23:53:59 -04:00
Bradlee Speice
ff9f2ac7b3 Slight refactor
Tried to refactor all the way to Kotlin, but ran into some casting issues ultimately after trying to work around Dagger.
2014-10-12 22:34:17 -04:00
Bradlee Speice
bfde7d5839 Fix NPE trying to open a book 2014-10-12 21:27:48 -04:00
Bradlee Speice
2ee16ceb4f Fix infinite scroll getting thrown into an infinite loop...
Ironic, no?
2014-09-27 19:20:27 -04:00
Bradlee Speice
b842ee1933 Forgot to include the UI Utils scroll files 2014-09-27 18:40:35 -04:00
Bradlee Speice
918f7688ba Now able to infinitely scroll bibles!
Tons of issues outstanding, but this is a huge accomplishment.
2014-09-16 23:37:08 -04:00
Bradlee Speice
df5700107d Kotlin WebView/Javascript client! 2014-09-14 21:56:09 -04:00
Bradlee Speice
d309d0de19 Filtered out the wrong books of the Bible. 2014-09-14 20:03:33 -04:00
Bradlee Speice
d74b684620 Force VerseContent to take in a non-null verse 2014-09-14 16:30:12 -04:00
Bradlee Speice
f9f8ea929f Add a TODO for JSON parsing in the future 2014-09-14 16:26:43 -04:00
Bradlee Speice
67b11b3ab0 Make sure the unit tests pass correctly 2014-09-12 22:36:53 -04:00
Bradlee Speice
cbb4b5fd14 Add a whole lot of debug goodies 2014-09-12 22:23:48 -04:00
Bradlee Speice
cb13dd64aa Get a first manager to Kotlin
Extension functions are fun...
2014-09-11 00:41:11 -04:00
Bradlee Speice
2ae714a935 Kotlin migration continues... 2014-09-10 23:31:16 -04:00
Bradlee Speice
f05e50292e Move parser to Kotlin 2014-09-10 22:41:34 -04:00
Bradlee Speice
3d8ff65af4 Bringing back Kotlin
I can do manual DI for testing, other Android classes can handle interfacing with Kotlin. From my testing, interop is quite smooth.
2014-09-09 23:31:32 -04:00
Bradlee Speice
4d0a8618a8 Displaying chapter and verse headers now 2014-09-09 23:05:58 -04:00
Bradlee Speice
3eb4b77cdb @NotNull was triggering some build errors... 2014-09-09 00:29:18 -04:00
Bradlee Speice
13417b2ad5 Strip out Kotlin
I just simply need DI too much, and I don't want to have a Java shell class for everything in Kotlin.
2014-09-09 00:10:12 -04:00
Bradlee Speice
24a384d30e Revert "The kotlin migration continues..."
I like my DI annotations too much...

This reverts commit 540426a0a2.
2014-09-08 23:45:20 -04:00