Add some slight refactoring

Unfortunately it's too hard to add the tests I wanted to
This commit is contained in:
Bradlee Speice
2014-11-22 00:21:38 -05:00
parent acbdc10116
commit 07b9d04933
4 changed files with 27 additions and 49 deletions

View File

@ -4,13 +4,10 @@ import android.annotation.SuppressLint;
import org.bspeice.minimalbible.service.format.osisparser.OsisParser;
import org.crosswire.jsword.book.OSISUtil;
import org.crosswire.jsword.passage.Verse;
import org.junit.Before;
import org.junit.Ignore;
import org.junit.Test;
import org.xml.sax.Attributes;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertFalse;
import static org.junit.Assert.assertTrue;
import static org.mockito.Mockito.mock;
@ -58,28 +55,4 @@ public class OsisParserTest {
parser.endElement("", "", "");
assertTrue(parser.getDoWrite().isEmpty());
}
// During initial development, I accidentally set up the verseContent
// as a value computed every time - so you'd get a new "content" every time
// you tried to update it. Thus, if you updated the content only once, you're fine.
// Try and update multiple times, and things would start going crazy.
// TODO: Why is this ignored?
@SuppressLint("NewApi")
@SuppressWarnings("unused")
@Ignore
public void ignoreTestVerseContentConsistent() {
String string1 = "1";
String string2 = "2";
// Yes, I need intimate knowledge of the state machine to run this test
// Also, Verse is final, so I can't mock that, which is why this test is ignored.
Verse mockVerse = mock(Verse.class);
parser.setVerse(mockVerse);
parser.getDoWrite().push(true);
parser.characters(string1.toCharArray(), 0, string1.length());
assertEquals(parser.getVerseContent().getContent(), string1);
parser.characters(string2.toCharArray(), 0, string2.length());
assertEquals(parser.getVerseContent().getContent(), string1 + string2);
}
}