From 135832859c0f36026086a51dbff9d4792fadc7cd Mon Sep 17 00:00:00 2001 From: Bradlee Speice Date: Mon, 19 May 2014 23:32:27 -0400 Subject: [PATCH] Add a couple TODOs for cleaning the Adapter --- .../minimalbible/activities/downloader/BookListAdapter.java | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/MinimalBible/src/main/java/org/bspeice/minimalbible/activities/downloader/BookListAdapter.java b/MinimalBible/src/main/java/org/bspeice/minimalbible/activities/downloader/BookListAdapter.java index c375968..09d1a9a 100644 --- a/MinimalBible/src/main/java/org/bspeice/minimalbible/activities/downloader/BookListAdapter.java +++ b/MinimalBible/src/main/java/org/bspeice/minimalbible/activities/downloader/BookListAdapter.java @@ -70,6 +70,12 @@ public class BookListAdapter extends BaseAdapter { public static class BookItemHolder { + // TODO: The holder should register and unregister itself for DownloadProgress events + // so that we can display live updates. + // TODO: Do we need to worry about lifecycle since this will be a static class? + // TODO: Switch this to its own class (non-static) so we can inject it, + // and it doesn't persist in memory + @InjectView(R.id.download_txt_item_acronym) TextView acronym; @InjectView(R.id.txt_download_item_name) TextView itemName; @InjectView(R.id.download_ibtn_download) ImageButton isDownloaded;