From 49953e9da4def960ca20e1e60ff8886c5523a0e8 Mon Sep 17 00:00:00 2001
From: Bradlee Speice <bradlee.speice@gmail.com>
Date: Tue, 23 Aug 2016 19:01:09 -0400
Subject: [PATCH] Switch `live` to a BoolParameter Instead of constructor
 argument

---
 metrik/tasks/base.py    | 11 ++++++-----
 test/tasks/test_base.py | 11 +++++++++++
 2 files changed, 17 insertions(+), 5 deletions(-)
 create mode 100644 test/tasks/test_base.py

diff --git a/metrik/tasks/base.py b/metrik/tasks/base.py
index 0c3d45f..dcd4bb2 100644
--- a/metrik/tasks/base.py
+++ b/metrik/tasks/base.py
@@ -3,7 +3,7 @@ from __future__ import print_function
 import logging
 
 from luigi import Task
-from luigi.parameter import DateMinuteParameter
+from luigi.parameter import DateMinuteParameter, BoolParameter
 
 from metrik.targets.mongo import MongoTarget
 from metrik.targets.noop import NoOpTarget
@@ -38,19 +38,20 @@ class MongoNoBackCreateTask(MongoCreateTask):
     # Have one parameter to make sure that the MongoTarget created by `super`
     # doesn't blow up.
     current_datetime = DateMinuteParameter()
+    live = BoolParameter()
 
-    def __init__(self, live=False, *args, **kwargs):
+    def __init__(self, *args, **kwargs):
         super(MongoNoBackCreateTask, self).__init__(*args, **kwargs)
-        self.live = live
         child_name = type(self).__name__
-        if not live:
-            logging.warning('Trying to create {child_name} without running'
+        if not self.live:
+            logging.warning('Trying to create {} without running'
                             ' live, errors potentially to ensue.'.format(child_name))
 
     def output(self):
         if self.live:
             return super(MongoNoBackCreateTask, self).output()
         else:
+            # TODO: return target closest to self.current_datetime
             return NoOpTarget()
 
     def run(self):
diff --git a/test/tasks/test_base.py b/test/tasks/test_base.py
new file mode 100644
index 0000000..77833a6
--- /dev/null
+++ b/test/tasks/test_base.py
@@ -0,0 +1,11 @@
+from unittest import TestCase
+from datetime import datetime
+
+from metrik.tasks.base import MongoNoBackCreateTask
+
+
+class BaseTaskTest(TestCase):
+
+    def test_mongo_no_back_live_false(self):
+        task = MongoNoBackCreateTask(current_datetime=datetime.now())
+        assert not task.live
\ No newline at end of file